Write ZIP64 End of Central Directory only if needed. #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems correct. Thanks. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Excel and LibreOffice fail to open an XLSX file compressed with SharpCompress when using ZIP64 (Excel is able to repair it, LibreOffice refuses it altogether).
Avoiding the ZIP64 End of Central Directory record when values are representable by the non-ZIP64 End of Central Directory record solves the issue.
This seems to be supported by the ZIP file format specification: "If one of the fields in the end of central directory record is too small to hold required data, the field SHOULD be set to -1 (0xFFFF or 0xFFFFFFFF) and the ZIP64 format record SHOULD be created." (https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT version 6.3.9, paragraph 4.4.1.4).