Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipArchive.RemoveEntry slow when removing in bulk #520

Open
DigVolSoft opened this issue Jun 22, 2020 · 2 comments
Open

ZipArchive.RemoveEntry slow when removing in bulk #520

DigVolSoft opened this issue Jun 22, 2020 · 2 comments

Comments

@DigVolSoft
Copy link

Nice library, thanks.

I've found that ZipArchive.RemoveEntry is slow when removing many entries (e.g. 1,000 in an archive of 60,000). It starts off ok but slows down to 1 file per second fairly quickly.

Could this be an issue of re-building between each removal, similar to #485
?

thanks

@adamhathcock
Copy link
Owner

Probably. Did you use the method in your code?

@DigVolSoft
Copy link
Author

Not in anything final - just currently experimenting with the library as it has nice support for multiple formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants