Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove deprecated gulp-util dependency #213

Merged
merged 7 commits into from
Jan 5, 2018
Merged

core: remove deprecated gulp-util dependency #213

merged 7 commits into from
Jan 5, 2018

Conversation

mjeanroy
Copy link
Contributor

Hi,

Since gulp-util has been deprecated, this PR replace gulp-util with alternative individual modules. Please see: https://github.com/gulpjs/gulp-util

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling 5ade7bf on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling 5ade7bf on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

shinnn
shinnn requested changes Dec 26, 2017
View reviewed changes
example/fail.js Outdated
@@ -3,7 +3,7 @@
// npm install gulp gulp-eslint

const gulp = require('gulp');
const gulpUtil = require('gulp-util');
const log = require('fancy-log');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this to fancyLog? I prefer explicitness.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling b3a7406 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling b3a7406 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@demurgos demurgos mentioned this pull request Dec 28, 2017
Closed
@demurgos
Copy link

@shinnn
Your request was addressed and the rest of the PR looks good. Could you merge this PR and publish an update to npm? I am currently going over multiple gulp plugins to fix the same issue. Some of them have dependencies on gulp-eslint so it would be nice to have it solved quickly for this library so the other plugins can be updated. Thanks :)

ninbryan
ninbryan reviewed Dec 29, 2017
View reviewed changes
test/util.js Outdated
@@ -216,7 +216,7 @@ describe('utility methods', () => {
it('should default to gutil.log', () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the test message be it('should default to fancyLog, () => {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the jsDoc should also be updated where [writable=gulp-util.log] is specified

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, what @ninbryan said. Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninbryan Good catch, thanks!

@coveralls
Copy link

coveralls commented Dec 30, 2017 •
edited

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling 2774485 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling 2774485 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling 2774485 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling fb32f1d on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling fb32f1d on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@mjeanroy
Copy link
Contributor Author

@shinnn I also updated the package-lock.json (I use node 9.3.0 / npm 5.5.1).

@demurgos
Copy link

demurgos commented Dec 30, 2017 •
edited by shinnn

[Unrelated to this "remove gulp-util" PR]

shinnn
shinnn requested changes Dec 30, 2017
View reviewed changes
Copy link
Collaborator

@shinnn shinnn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add v4.0.2 changelog.

@mjeanroy
Copy link
Contributor Author

@shinnn I updated CHANGELOG.md. Regarding package-lock.json, do you want me to revert this change?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling be32cf2 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling be32cf2 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@shinnn
Copy link
Collaborator

shinnn commented Dec 30, 2017

Regarding package-lock.json, do you want me to revert this change?

No. Just ignore @demurgos's comment, I've already deleted it though.

@demurgos demurgos mentioned this pull request Dec 30, 2017
Closed
@demurgos
Copy link

demurgos commented Dec 30, 2017 •
edited

Sorry for my comment about the lock file update. The use or not of lock files has no clear answer and it was not the place for this PR to discuss it.

@mjeanroy
It's good that you updated the lock file, you can effectively ignore my previous comment.

shinnn
shinnn requested changes Jan 4, 2018
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
# Changelog

## 4.0.2

* Remove deprecated [`gulp-util`](https://github.com/gulpjs/gulp-util) dependency and use individual modules instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the last . for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+0.005%) to 99.31% when pulling fd70515 on mjeanroy:refactor-remove-deprecated-gulp-util-dependency into 35eae57 on adametry:master.

@shinnn shinnn merged commit b48a04a into adametry:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninbryan ninbryan ninbryan left review comments

@shinnn shinnn shinnn approved these changes

@demurgos demurgos demurgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mjeanroy @coveralls @demurgos @shinnn @ninbryan