Added new checks C413, C414, C415, and C416. #190
Conversation
| @@ -18,7 +18,7 @@ def test_version(flake8dir): | |||
| def test_C400_pass_1(flake8dir): | |||
| flake8dir.make_example_py( | |||
| """ | |||
| foo = [x for x in range(10)] | |||
| foo = [x + 1 for x in range(10)] | |||
There was a problem hiding this comment.
Note that many of the tests needed tweaking so as not to violate the new C416 rule.
| # Column offset for list comprehensions was incorrect in Python < 3.8. | ||
| # See https://bugs.python.org/issue31241 for details. | ||
| col_offset = 1 if sys.version_info >= (3, 8) else 2 |
|
Thanks for these - I'll get around to reviewing soon! |
| msg = ( | ||
| msg.rstrip(".") | ||
| + " - toggle reverse argument to sorted()." | ||
| ) |
There was a problem hiding this comment.
I couldn't follow this so I've rewritten it with a for loop and an extra message piece.
Weird. The box is ticked (which is the default). Will try toggling it off and on. |
|
It was my fault - my git invocation was off so I was trying to push to a branch in your repo called |
…n reversed/set/sorted().
…ng list/set(). Fixes #163.
There was a problem hiding this comment.
Thanks very much!
The only thing I'd change is to move to one test per case like the other tests. Batching them does increase speed with flake8 in subprocesses but if something fails it's harder to track down the cause. Anyway I think I'll have a pass at simplifying all the tests. Will post again when this is released.
|
Released in 3.1.0: https://pypi.org/project/flake8-comprehensions/3.1.0/ |
Hi!
I've added a few additional checks that I think are helpful:
sorted().list/set/sorted/tuple().reversed/set/sorted().list/set().