Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: fix bug in conditions #253

Open
sergkudinov opened this issue Jan 21, 2021 · 0 comments
Open

engine: fix bug in conditions #253

sergkudinov opened this issue Jan 21, 2021 · 0 comments
Assignees
Labels

Comments

@sergkudinov
Copy link
Contributor

sergkudinov commented Jan 21, 2021

Each condition deletes parent action what calls nikita:session:resolved hook of the root action.

To reproduce

Run test on engine-conditions branch :

git checkout engine-conditions
cd packages/core
npx mocha test/actions/log/cli.coffee

Error:

1) actions.log.cli
       session events
         when resolved with conditions (local):

      AssertionError: expected Array [
  'localhost      ♥\n',
  'localhost      ♥\n',
  'localhost      ♥\n',
  'localhost      ✘\n',
  'localhost      ♥\n',
  'localhost      ✘\n',
  'localhost   h1 : h2   ✔\n',
  'localhost   h1   ✔\n',
  'localhost      ♥\n'
] to equal Array [ 'localhost   h1   ✔\n', 'localhost      ♥\n' ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants