Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/chown : false check when uid or gid passed is NaN #121

Open
IDerr opened this issue Sep 6, 2017 · 1 comment
Open

system/chown : false check when uid or gid passed is NaN #121

IDerr opened this issue Sep 6, 2017 · 1 comment
Labels

Comments

@IDerr
Copy link
Contributor

IDerr commented Sep 6, 2017

Hi,
When the uid or gid is nan :
if ((!options.uid || options.stat.uid === options.uid) && (!options.gid || options.stat.gid === options.gid))

!options.uid will return true

[5.DEBUG nikita/lib/chown] "Entering chown"
[6.INFO nikita/lib/chown] "stat.uid=0 uid=NaN stat.gid=0 gid=NaN"
[6.INFO nikita/lib/chown] "uidcheck=true gidCheck=true"
[6.INFO nikita/lib/chown] "Matching ownerships on 'mydir'"

Thanks for your work.

@IDerr IDerr added the bug label Sep 6, 2017
@wdavidw
Copy link
Member

wdavidw commented Sep 6, 2017

Do you feel like submitting a pull request, i'll be happy to review it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants