Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: clean up documentation and pass the tests #119

Open
wdavidw opened this issue Jul 30, 2017 · 0 comments
Open

docker: clean up documentation and pass the tests #119

wdavidw opened this issue Jul 30, 2017 · 0 comments
Assignees

Comments

@wdavidw
Copy link
Member

wdavidw commented Jul 30, 2017

This is one of the last code which no longer pass the tests.

Also, the doc doesn't follow the general guideline. I already spend quite a good amount of time cleaning it up, so please, @lucasbak and @Pierrotws , take the time to get inspirations from the diff so that i dont have to cleanup documentation every now and then. I you disagree with the coding style, open a new issue, and we'll discuss it, i'm not against improving it, but enforcing it in your code isnt good since it create disparities.

wdavidw added a commit that referenced this issue Jul 30, 2017
wdavidw added a commit that referenced this issue Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants