Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no-unresolved" flagged for import of csv-stringify #372

Open
himynameisdave opened this issue Dec 1, 2022 · 3 comments
Open

"no-unresolved" flagged for import of csv-stringify #372

himynameisdave opened this issue Dec 1, 2022 · 3 comments

Comments

@himynameisdave
Copy link

Describe the bug

Not exactly a bug because it's not truly blocking me and I'm sure it's got something to do with my environment, but wanted to post here to help figure it out.

Basically I've upgraded to the latest version of this package and updated my imports to 'csv-stringify/sync', but my editor is flagging it as an unresolved dependency (even tho they path is resolved when I hover it). Everything seems to work fine, it's just annoying that this is being flagged.

Using TypeScript here as well, if that is relevant.

To Reproduce

  • Updated csv-stringify from 5.6.5 to 6.2.3
  • Change imports from...
    import * as stringify from 'csv-stringify/lib/sync';
    
    ...to...
    import { stringify } from 'csv-stringify/sync';
    

Additional context

image

@wdavidw
Copy link
Member

wdavidw commented Dec 1, 2022

I am no export in the TS field, anyone ?

@nwalters512
Copy link

This is because this package now uses exports to declare what files are available, and eslint-plugin-import doesn't yet support that: import-js/eslint-plugin-import#1810.

Adding a file sync.js or sync/index.js to the published version of these packages would resolve this.

@karlhorky
Copy link

karlhorky commented Aug 25, 2023

Hm, I just tried upgrading to csv@6.3.2 (which also includes the changes from #397) and I no longer need an ESLint disable for import/no-unresolved (not sure if this was caused by this change or some other earlier change) - can anyone else confirm that this is fixed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants