Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support TypeScript moduleResolution node16 #368

Merged
merged 1 commit into from Nov 8, 2022

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Nov 8, 2022

Without this change, trying to import this library when using moduleResolution node16 or nodenext gives the following error:

node_modules/csv-parse/dist/esm/sync.d.ts:2:25 - error TS2835: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './index.js'?

2 import { Options } from './index';
                          ~~~~~~~~~

node_modules/csv-parse/dist/esm/sync.d.ts:11:8 - error TS2835: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './index.js'?

11 } from './index';
          ~~~~~~~~~

node_modules/csv-stringify/dist/esm/sync.d.ts:2:32 - error TS2835: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './index.js'?

2 import { Input, Options } from './index'
                                 ~~~~~~~~~

node_modules/csv-stringify/dist/esm/sync.d.ts:12:8 - error TS2835: Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './index.js'?

12 } from './index';
          ~~~~~~~~~


Found 4 errors in 2 files.

Errors  Files
     2  node_modules/csv-parse/dist/esm/sync.d.ts:2
     2  node_modules/csv-stringify/dist/esm/sync.d.ts:2

@wdavidw
Copy link
Member

wdavidw commented Nov 8, 2022

Sorry it tooks me so long to review your PR. The following versions were published:

  • csv-generate@4.2.1
  • csv-parse@5.3.2
  • csv-stringify@6.2.1
  • csv@6.2.2
  • stream-transform@3.2.1

@LinusU
Copy link
Contributor Author

LinusU commented Nov 9, 2022

Thank you for the quick publish 🙏

@LinusU LinusU deleted the ts-module-resolution branch November 9, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants