We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipient::do_send()
Addr::do_send()
Recipient::do_send() should not return a Result, same as Addr::do_send() does.
Result
Currently Recipient::do_send() is identical in behavior with Recipient::try_send(), this seems to be an oversight.
Recipient::try_send()
Consume the Result inside the method body, same as Addr::do_send() does: https://github.com/actix/actix/blob/master/src/address/mod.rs#L99
This is a breaking API change, but a consistency improvement, users of Recipient::do_send() presumably already throw away the Result.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Expected Behavior
Recipient::do_send()
should not return aResult
, same asAddr::do_send()
does.Current Behavior
Currently
Recipient::do_send()
is identical in behavior withRecipient::try_send()
, this seems to be an oversight.Possible Solution
Consume the Result inside the method body, same as
Addr::do_send()
does:https://github.com/actix/actix/blob/master/src/address/mod.rs#L99
Context
This is a breaking API change, but a consistency improvement, users of
Recipient::do_send()
presumably already throw away the Result.The text was updated successfully, but these errors were encountered: