Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear conn_data on HttpRequest drop #2742

Merged
merged 3 commits into from Apr 23, 2022
Merged

clear conn_data on HttpRequest drop #2742

merged 3 commits into from Apr 23, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Apr 23, 2022

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Currently conn data is cleared too late.

fixes #2740

@robjtede robjtede added B-semver-patch A-web project: actix-web labels Apr 23, 2022
@robjtede robjtede marked this pull request as ready for review April 23, 2022 11:47
@robjtede robjtede enabled auto-merge (squash) April 23, 2022 12:10
@robjtede robjtede disabled auto-merge April 23, 2022 12:35
@robjtede robjtede merged commit f2cacc4 into master Apr 23, 2022
@robjtede robjtede deleted the clean-conn-data branch April 23, 2022 12:35
@robjtede robjtede added this to the actix-web v4.1 milestone Apr 23, 2022
@Schniz
Copy link

Schniz commented Apr 23, 2022

Woah @robjtede thanks for the speedy fix. Can’t wait for this to release 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on_connect extensions not dropping after connection close
2 participants