Add ServiceRequest::extract
#2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ServiceRequest would go in the future. Adding shortcut like this is pointless and add more burden to maintainer and user for it's short life span. |
robjtede
force-pushed
the
extract-from-service-request
branch
from
78f0406
to
95cff76
Compare
robjtede
approved these changes
Apr 2, 2022
|
Great QoL change. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
A shortcut to make it easier to leverage extractors in middleware implementations (i.e. do not require newcomers to go through packing/unpacking of
ServiceRequestinto its inner components).