Add ServiceConfig::default_service
#2338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `App` struct supports a "default" service which will be called when there are no other matching services available. I propose that we support adding this default service from the `ServiceConfig` struct, which will enable it to be used from `App::configure`. Currently if you want to test a default service (if you're creating a proxy for example) you must re-specify this default service each time you construct your app. This change will allow users to put their default services into the shared `App::configure` helper.
aliemjay
requested changes
Oct 10, 2021
Comment on lines
+208
to
+211
| if let Some(default) = cfg.default { | ||
| self.default = Some(default); | ||
| } | ||
|
|
There was a problem hiding this comment.
We should have this for Scope::configure as well.
robjtede
added
C-improvement
|
The source branch does not allow maintainer edits so i've carried on the work in #2743 with attribution back here. Thanks for the contribution. |
robjtede
added a commit
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
The
Appstruct supports a "default" service which will be called when thereare no other matching services available. I propose that we support adding this
default service from the
ServiceConfigstruct, which will enable it to be usedfrom
App::configure. Currently if you want to test a default service (ifyou're creating a proxy for example) you must re-specify this default service
each time you construct your app. This change will allow users to put their
default services into the shared
App::configurehelper.