Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrono change to v0.4.30 breaks the build of actix-http-1.0.1 #3135

Closed
bryan-roberts opened this issue Sep 14, 2023 · 2 comments
Closed

Chrono change to v0.4.30 breaks the build of actix-http-1.0.1 #3135

bryan-roberts opened this issue Sep 14, 2023 · 2 comments
Labels
A-http project: actix-http v3.x wontfix

Comments

@bryan-roberts
Copy link

This is described by Chrono as a "SemVer-breaking change, we expect the risk of downstream users experiencing actual incompatibility to be exceedingly limited"
chronotope/chrono#1268

cookie.set_expires(time::now() - Duration::days(365));
| ^ no implementation for Tm - chrono::Duration
|
= help: the trait Sub<chrono::Duration> is not implemented for Tm
= help: the following other types implement trait Sub<Rhs>:
<Tm as Subtime::Duration>

https://github.com/actix/actix-web/blob/7880d5e2bf10d872ba340eb2230151479eaea4f4/actix-http/src/cookie/jar.rs#L226C25-L226C25

@robjtede robjtede added wontfix A-http project: actix-http v3.x labels Sep 14, 2023
@robjtede
Copy link
Member

robjtede commented Sep 14, 2023

Sorry to inform you that the Actix Web v3.x is not being maintained and will not receive a fix for this issue.

I can only offer to help you update to Actix Web v4.

As a temporary solution you can pin chrono to v0.4.29 in your manifest file.

@bryan-roberts
Copy link
Author

For reference this is what I had to do to specify the exact version before the breaking changes.

chrono = { version = "= 0.4.29" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http v3.x wontfix
Projects
None yet
Development

No branches or pull requests

2 participants