replace askama_escape in favor of v_htmlescape #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of Is there any benefit here besides less dependencies? Is it faster to use? |
|
I'm assuming the unsafe is largely to do with running SSE/AVX code. |
|
If necessary I can put more test coverage. And I have had the fuzzy tests for hours without failures. Anything you need, say it and I'll implement it. |
|
@cetra3 https://github.com/rust-lang/rust/search?q=unsafe Is there a problem that needs to be fixed? This library was already used before in actix for a long time and has not given any problem. And of course it is many times faster than anyone. I invite you to look at the benchmarks. |
robjtede
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
n the new version, v_htmlescape@0.15, it has no dependencies and is a generated file of about 1500 lines of code. Compile time is minimal and it is optimized with simd instructions on x86 and x86_64.
Sorry for taking so long.
PR Checklist
Tests for the changes have been added / updated.Documentation comments have been added / updated.A changelog entry has been made for the appropriate packages.Previous PR: #2402