Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 4.1 group #2781

Merged
merged 5 commits into from Jun 11, 2022
Merged

release 4.1 group #2781

merged 5 commits into from Jun 11, 2022

Conversation

robjtede
Copy link
Member

PR Type

Releases

PR Checklist

  • A changelog entry has been made for the appropriate packages.
  • (Team) Label with affected crates and semver status.

@robjtede robjtede added A-files project: actix-files A-codegen project: actix-web-codegen A-http project: actix-http A-web project: actix-web labels Jun 11, 2022
@robjtede robjtede requested a review from JohnTitor June 11, 2022 12:49
@robjtede
Copy link
Member Author

@JohnTitor If you're happy with this would you mind publishing them to crates.io too, please. GitHub releases are drafted.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTitor JohnTitor merged commit 43671ae into master Jun 11, 2022
@JohnTitor JohnTitor deleted the rel-4.1 branch June 11, 2022 15:15
@JohnTitor
Copy link
Member

JohnTitor commented Jun 11, 2022

Hmm, I've encountered gyscos/zstd-rs#147 and I cannot publish actix-http and -web.
Because actix-http will use the published version of actix-web when publishing, an error like below occurs:

  failed to select a version for `zstd`.
      ... required by package `actix-http v3.1.0`
  versions that meet the requirements `^0.11` are: 0.11.2+zstd.1.5.2, 0.11.1+zstd.1.5.2, 0.11.0+zstd.1.5.2

  the package `zstd` links to the native library `zstd`, but it conflicts with a previous package which links to `zstd` as well:
  package `zstd-safe v4.1.4+zstd.1.5.2`
      ... which satisfies dependency `zstd-safe = "=4.1.4"` of package `zstd v0.10.0+zstd.1.5.2`
      ... which satisfies dependency `zstd = "^0.10"` of package `actix-http v3.0.0`
      ... which satisfies dependency `actix-http = "^3.0.0"` of package `actix-web v4.0.0`
      ... which satisfies dependency `actix-web = "^4"` of package `actix-http v3.1.0`

@robjtede Any idea? Maybe we could disable the -web dev-dep on -http temporarily? Or actix-web = { git = "https://github.com/actix/actix-web", rev = "43671ae4aaf2c20150fd1e5ca54055eb5d114273" }?

@JohnTitor
Copy link
Member

Avoided the issue with this: 3926416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen project: actix-web-codegen A-files project: actix-files A-http project: actix-http A-web project: actix-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants