Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ResponseError for Infallible #2769

Merged
merged 2 commits into from May 30, 2022
Merged

Implement ResponseError for Infallible #2769

merged 2 commits into from May 30, 2022

Conversation

SabrinaJewson
Copy link
Contributor

@SabrinaJewson SabrinaJewson commented May 30, 2022 •
edited by robjtede

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
    • N/A? I can’t really add tests that wouldn’t just be repeating what the code says
  • Documentation comments have been added / updated.
    • Also N/A IMO, I don’t think it really needs docs
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

I saw someone on Discord encounter a problem because it wasn’t present earlier today. It seems reasonable, so I added it. The use case was in the Result returned from actix_form_data::Field::file.

@robjtede robjtede added A-web project: actix-web B-semver-minor labels May 30, 2022
@robjtede robjtede added this to the actix-web v4.1 milestone May 30, 2022
@SabrinaJewson
Copy link
Contributor Author

Ah…CI is failing but it doesn’t seem to be related to this PR, just that hashbrown no longer compiles on the MSRV.

robjtede
robjtede approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat change. Thank you 👍

We'll sort through CI later.

@robjtede robjtede merged commit dce57a7 into actix:master May 30, 2022
@SabrinaJewson SabrinaJewson deleted the infallible-response-error branch May 30, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
actix-web v4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SabrinaJewson @robjtede