routes macro allowing multiple paths per handler
#2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ModProg
force-pushed
the
advanced_route_macro
branch
from
8a88765
to
f73c540
Compare
ModProg
changed the title
routes macroroutes macro allowing multiple paths per handler
|
This is now working and documented (already using it my self in https://github.com/ModProg/paste). Would like some feedback on the code to get this in a merge able state ASAP, so I don't need to run on a git version forever. |
Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
|
Is there anything left for me to do to make this PR mergeable? |
|
I haven't reviewed yet but I'm targetting this for v4.2, not the upcoming v4.1 so it will be merged after that release. |
this is dead code from back when .to and .to_async were different ways to add a service
robjtede
approved these changes
Jul 4, 2022
|
CI issue was just missing a feature flag on Thanks for the contribution. |
|
Thanks, really looking forward to 4.2 now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Overview
Adds support for
routesmacro, allowing multiple paths and methods to be specified.Closes #2713