Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stuck connection when handler doesn't read payload #2624

Merged
merged 5 commits into from Feb 3, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 2, 2022

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

  • drops connection if dispatcher's state indicated there are outstanding bytes
  • otherwise clean dispatcher ready for next pipelined or keep-alive request

closes #2357

- drops connection if dispatcher's state indicated there are outstanding bytes
- otherwise clean dispatcher ready for next pipelined or keep-alive request
@robjtede robjtede added this to the actix-web v4 milestone Feb 2, 2022
@robjtede robjtede requested a review from a team February 2, 2022 20:36
@robjtede robjtede added A-http project: actix-http B-semver-patch labels Feb 3, 2022
@robjtede robjtede merged commit 5ca42df into master Feb 3, 2022
@robjtede robjtede deleted the fix-stuck-requests branch February 3, 2022 07:03
robjtede added a commit that referenced this pull request Jun 11, 2022
robjtede added a commit that referenced this pull request Jun 11, 2022
robjtede added a commit that referenced this pull request Jun 11, 2022
* revert broken fix in #2624

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http project: actix-http B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hang or protocol error when sending early response to a POST request with delayed body
2 participants