re-work from request macro. #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakeshadow
added
A-web
ibraheemdev
reviewed
Nov 29, 2021
Comment on lines
99
to
+100
| pin-project = "1.0.0" | ||
| pin-project-lite = "0.2.7" |
There was a problem hiding this comment.
pin-project and pin-project-lite?
There was a problem hiding this comment.
we're migrating as we go, both crates are in the dep graph anyway
There was a problem hiding this comment.
The only blocker of removing pin-projectbesides this macro was the pin drop attr used in logger middleware.
pin-project-lite 0.2.7 added this feature so at this point it's possible to remove pin-project from actix-web
robjtede
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor
PR Checklist
Overview
Reduce size of future generated. Depend on the type can be up to 30%.
Enable
pin_project_litein macro.