Adjust JSON limit to 2MB and report on sizes #2162
Merged
+74
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Other
PR Checklist
Overview
This adjusts the default limit of JSON payloads to 2mb from 32kb and adjusts the error to include what the limits are when they're hit. As this changes the error enum & has possibly knock on effects to memory usage by allowing more through this is probably considered a breaking change.
To justify the increase, I have looked at other defaults in other software for what their limits are:
(Honestly, I'd much prefer having no limit at all by default as these things seem to have a way of coming back to bite at unrealistic times, like 2am on a saturday morning!)