Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional cookies features #1981

Merged
merged 7 commits into from Feb 13, 2021
Merged

optional cookies features #1981

merged 7 commits into from Feb 13, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 12, 2021 •
edited

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
    • in the form of --no-default-features checks in CI
  • Documentation comments have been added / updated.
    • in the form of documenting crate features of actix-http in root doc
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Cookies are now optional, disabled by default in -http and enabled by default in awc and -web.

@robjtede robjtede added A-awc project: awc A-http project: actix-http B-semver-minor A-web project: actix-web labels Feb 12, 2021
@robjtede robjtede requested review from a team February 13, 2021 05:03
fakeshadow
fakeshadow approved these changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@fakeshadow fakeshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This make actix-web more light for apps that not utlize cookie features.

@robjtede robjtede merged commit 3279070 into master Feb 13, 2021
@robjtede robjtede deleted the opt-cookies branch February 13, 2021 15:08
@dependabot dependabot bot mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fakeshadow fakeshadow fakeshadow approved these changes

Assignees
No one assigned
Labels
A-awc project: awc A-http project: actix-http A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robjtede @fakeshadow