Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding app_data to ServiceConfig #1758

Merged
merged 9 commits into from Oct 26, 2020
Merged

Adding app_data to ServiceConfig #1758

merged 9 commits into from Oct 26, 2020

Conversation

augustocdias
Copy link
Contributor

PR Type

Adding app_data for ServiceConfig struct.

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Currently it is not possible to register app_data through the App::configure builder.
This will essentially merge the app_data from the ServiceConfig with the App's.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should include Scope::configure.

actix-http/src/extensions.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@robjtede robjtede requested a review from a team October 26, 2020 13:48
augustocdias and others added 4 commits October 26, 2020 15:12
src/scope.rs Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #1758 into master will increase coverage by 0.03%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1758      +/-   ##
==========================================
+ Coverage   53.78%   53.82%   +0.03%     
==========================================
  Files         129      126       -3     
  Lines       12060    12071      +11     
==========================================
+ Hits         6487     6497      +10     
- Misses       5573     5574       +1     
Impacted Files Coverage Δ
src/config.rs 92.55% <88.88%> (-0.56%) ⬇️
actix-http/src/extensions.rs 58.33% <100.00%> (+3.78%) ⬆️
src/app.rs 98.99% <100.00%> (+<0.01%) ⬆️
src/scope.rs 93.45% <100.00%> (+0.01%) ⬆️
actix-http/src/header/common/mod.rs 10.00% <0.00%> (-1.12%) ⬇️
actix-http/src/header/common/allow.rs
actix-http/src/header/common/expires.rs
actix-http/src/header/common/content_language.rs
actix-http/src/header/common/etag.rs
actix-http/src/header/common/last_modified.rs
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20078fe...b492e56. Read the comment docs.

@robjtede robjtede changed the title Adding app_data to ServiceConfig (#1757) Adding app_data to ServiceConfig Oct 26, 2020
@robjtede robjtede merged commit 7030bf5 into actix:master Oct 26, 2020
@robjtede robjtede linked an issue Oct 29, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add app_data equivalent to ServiceConfig
5 participants