New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding app_data to ServiceConfig #1758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this should include Scope::configure
.
Co-authored-by: Rob Ede <robjtede@icloud.com>
Co-authored-by: Rob Ede <robjtede@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
+ Coverage 53.78% 53.82% +0.03%
==========================================
Files 129 126 -3
Lines 12060 12071 +11
==========================================
+ Hits 6487 6497 +10
- Misses 5573 5574 +1
Continue to review full report at Codecov.
|
PR Type
Adding
app_data
forServiceConfig
struct.PR Checklist
Check your PR fulfills the following:
Overview
Currently it is not possible to register
app_data
through theApp::configure
builder.This will essentially merge the
app_data
from theServiceConfig
with theApp
's.