Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use idenity encoding on client if no compression features are enabled #1737

Merged
merged 9 commits into from Oct 24, 2020
Merged

use idenity encoding on client if no compression features are enabled #1737

merged 9 commits into from Oct 24, 2020

Conversation

j-brn
Copy link
Contributor

@j-brn j-brn commented Oct 16, 2020

PR Type

Bugfix

Overview

Fixes #1731 by using Accept-Encoding: identity when no compression feature is enabled.

robjtede
robjtede reviewed Oct 16, 2020
View reviewed changes
awc/src/request.rs Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 16, 2020 •
edited

Codecov Report

Merging #1737 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files         127      127           
  Lines       12062    12062           
=======================================
  Hits         6487     6487           
  Misses       5575     5575
Impacted Files Coverage Δ
awc/src/request.rs 25.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e7cec...70519f9. Read the comment docs.

@robjtede robjtede changed the title AWC: Use Accept-Encoding=idenity if no compression feature is enabled (#1731) use idenity encoding on client if no compression features areenabled Oct 16, 2020
@robjtede robjtede self-requested a review October 16, 2020 22:54
@JohnTitor JohnTitor changed the title use idenity encoding on client if no compression features areenabled use idenity encoding on client if no compression features are enabled Oct 19, 2020
JohnTitor
JohnTitor approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add an entry to the changelog as this changes the current behavior as a bug fix?

@j-brn
Copy link
Contributor Author

j-brn commented Oct 19, 2020

Looks good, could you add an entry to the changelog as this changes the current behavior as a bug fix?

Added in c2aeea5

robjtede
robjtede reviewed Oct 19, 2020
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
robjtede
robjtede reviewed Oct 19, 2020
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
@robjtede robjtede merged commit 06e5042 into actix:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
A-awc project: awc B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable compression headers when disabling compression feature
4 participants
@j-brn @codecov-io @robjtede @JohnTitor