Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release beta 4 #1659

Merged
merged 4 commits into from Sep 9, 2020
Merged

prepare release beta 4 #1659

merged 4 commits into from Sep 9, 2020

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Sep 9, 2020

i think this will be the last beta 馃殌

@robjtede robjtede requested review from a team September 9, 2020 08:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #1659 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
- Coverage   53.35%   53.28%   -0.07%     
==========================================
  Files         117      121       +4     
  Lines       11813    11828      +15     
==========================================
  Hits         6303     6303              
- Misses       5510     5525      +15     
Impacted Files Coverage 螖
actix-http/src/header/common/mod.rs 10.00% <0.00%> (-6.67%) 猬囷笍
actix-http/src/header/common/accept.rs 0.00% <0.00%> (酶)
...ctix-http/src/header/common/if_unmodified_since.rs 0.00% <0.00%> (酶)
actix-http/src/header/common/etag.rs 0.00% <0.00%> (酶)
actix-http/src/header/common/if_match.rs 0.00% <0.00%> (酶)
actix-http/src/header/common/accept_charset.rs 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3a27580...483977f. Read the comment docs.

Copy link
Member

@Neopallium Neopallium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it wait for #1656 to get merged, so that new version will have better docs already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants