- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improve awc websocket docs #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 53.20% 53.19% -0.01%
==========================================
Files 123 123
Lines 11832 11833 +1
==========================================
Hits 6295 6295
- Misses 5537 5538 +1
Continue to review full report at Codecov.
|
Hm. I'm not sure why CI fails on windows, but passes on Linux / macOS. It doesn't seem that doctest has some platform-specific code. |
Looks like an issue getting a cert for TLS: "the handshake failed: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl\statem\statem_clnt.c:1924:: unable to get local issuer certificate" I don't think it is related to this PR. |
Would it work with "ws://echo.websocket.org" ws instead of wss? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some wording adjustments, otherwise LGTM
Co-authored-by: Rob Ede <robjtede@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution 👍
PR Type
Docs
PR Checklist
Check your PR fulfills the following:
Overview
When I first tried to use
awc
, I had some problems with understanding how to use it with WebSocket.I thought an example will be very helpful for readers.