Configurable trailing slash behaviour for NormalizePath

[ljoonal]

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

Currently NormalizePath always adds a trailing slash. This change would make it configurable to either follow that style, or to always trim the trailing slash instead.

Will be a breaking change to NormalizePath usage, since middleware::NormalizePath will need to be replaced by middleware::NormalizePath::default() or ::new(...) when creating the middleware.

Closes #1612

[robjtede]

Looks really good so far. Just left some initial thoughts and obviously the checks are failing from the doc comment in condition.rs.

[robjtede]

Thanks for those updates. Add a CHANGELOG.md entry and a note to MIGRATION.md. Also check the job failure to see what needs updating.

[codecov-commenter]

Codecov Report

Merging #1639 into master will increase coverage by 0.01%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   53.21%   53.22%   +0.01%     
==========================================
  Files         124      126       +2     
  Lines       11760    11796      +36     
==========================================
+ Hits         6258     6279      +21     
- Misses       5502     5517      +15     

Impacted Files	Coverage Δ
src/middleware/condition.rs	86.11% <ø> (ø)
src/middleware/normalize.rs	93.93% <89.28%> (-2.07%)	⬇️
actix-http/src/header/common/mod.rs	7.69% <0.00%> (-2.31%)	⬇️
actix-http/src/header/common/accept.rs	0.00% <0.00%> (ø)
actix-http/src/header/common/expires.rs
actix-http/src/header/common/if_none_match.rs
actix-http/src/header/common/last_modified.rs	0.00% <0.00%> (ø)
actix-http/src/header/common/accept_language.rs	0.00% <0.00%> (ø)
actix-http/src/header/common/content_language.rs	0.00% <0.00%> (ø)
actix-http/src/header/common/allow.rs	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3892a95...653cfee. Read the comment docs.

[robjtede]

Great work, thanks 👍

[patrickelectric]

Hey, any plan to release it ? It's an awesome feature, I was able to have a /path|path/ to the same get method, and now with 2.0.0 appears to be not possible at all sadly.