Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rustls panic when generating dns name from ip #296

Merged
merged 4 commits into from Mar 24, 2021
Merged

fix rustls panic when generating dns name from ip #296

merged 4 commits into from Mar 24, 2021

Conversation

fakeshadow
Copy link
Contributor

@fakeshadow fakeshadow commented Mar 24, 2021 •
edited by robjtede

PR Type

Bug Fix

PR Checklist

Check your PR fulfills the following:

  • Add changelog entry.
  • Format code with the latest stable rustfmt

Overview

Return error instead of panic when rustls failed to generate Dns name ref from a given host(e.g. A host with ip address).

Closes actix/actix-web#2100

robjtede
robjtede approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 👍🏻

can you add changelog entry

@robjtede
Copy link
Member

robjtede commented Mar 24, 2021 •
edited

merge at your leisure when checks done

@fakeshadow fakeshadow merged commit a3c9ebc into master Mar 24, 2021
@fakeshadow fakeshadow deleted the fix/rustls_ip_host_panic branch March 24, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awc panics if redirected to an IP address (not a DNS name) when using rustls
2 participants
@fakeshadow @robjtede