Add native tls support for actix_tls::connect module #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakeshadow
changed the title
robjtede
reviewed
Mar 24, 2021
robjtede
approved these changes
Mar 26, 2021
|
theres a conflict i can't solve in the UI apparently |
robjtede
force-pushed
the
feature/actix_tls_connect_native_tls
branch
from
e76097d
to
39b7570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
Check your PR fulfills the following:
Overview
native tls was lacking on client connect module while impled in server accept module.
This PR add support for it in client connect module and can be enabled with
native-tlsfeature.No test was added for this feature as current tests does not actually test any tls connectors(no matter openssl, rustls or native-tls). So there is no point adding test for it until this issue sorted out.
Some clippy warning fix for nightly has also been worked into this PR.