Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix-service: Fix clippy warning in benches #174

Merged
merged 1 commit into from Aug 7, 2020
Merged

actix-service: Fix clippy warning in benches #174

merged 1 commit into from Aug 7, 2020

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 7, 2020

PR Type

Refactor

PR Checklist

Check your PR fulfills the following:

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Currently benches code for actix-service emits a clippy::let_and_return warning. This minor PR fixes it.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #174 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   60.45%   60.41%   -0.05%     
==========================================
  Files          73       73              
  Lines        4785     4785              
==========================================
- Hits         2893     2891       -2     
- Misses       1892     1894       +2     
Impacted Files Coverage Δ
actix-service/benches/and_then.rs 0.00% <ø> (ø)
actix-service/benches/unsafecell_vs_refcell.rs 0.00% <ø> (ø)
actix-connect/tests/test_connect.rs 87.69% <0.00%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4b708...14ff4d1. Read the comment docs.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit afb0a3c into actix:master Aug 7, 2020
@popzxc popzxc deleted the fix-clippy-warnings branch August 7, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants