Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bcodec decode #162

Merged
merged 1 commit into from Jul 20, 2020
Merged

Simplify bcodec decode #162

merged 1 commit into from Jul 20, 2020

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Jul 20, 2020

robjtede
robjtede approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #162 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   60.50%   60.51%   +0.01%     
==========================================
  Files          74       74              
  Lines        4790     4789       -1     
==========================================
  Hits         2898     2898              
+ Misses       1892     1891       -1
Impacted Files Coverage Δ
actix-codec/src/bcodec.rs 42.85% <0.00%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0bd7c...633a2e1. Read the comment docs.

JohnTitor
JohnTitor approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 5d6d309 into actix:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zzau13 @robjtede @JohnTitor