Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bcodec encode performance #157

Merged
merged 1 commit into from Jul 19, 2020
Merged

Improve bcodec encode performance #157

merged 1 commit into from Jul 19, 2020

Conversation

zzau13
Copy link
Contributor

@zzau13 zzau13 commented Jul 19, 2020

Remove repeat calls to reverve method. Stop treating itemsince it has the assured drop. Add the inline attribute because the resulting body is just one line.

The same as ntex-rs/ntex#22

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #157 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   60.50%   60.50%   -0.01%     
==========================================
  Files          74       74              
  Lines        4791     4790       -1     
==========================================
- Hits         2899     2898       -1     
  Misses       1892     1892              
Impacted Files Coverage Δ
actix-codec/src/bcodec.rs 37.50% <100.00%> (-6.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67e38b...0ae8edf. Read the comment docs.

Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

Can you put a mention of the perf improvement in changelog please.

@robjtede robjtede merged commit 8d0bd7c into actix:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants