Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session: Add option for redis/tokio-rustls-comp #342

Open
ryanseipp opened this issue Sep 26, 2023 · 0 comments · May be fixed by #402
Open

Session: Add option for redis/tokio-rustls-comp #342

ryanseipp opened this issue Sep 26, 2023 · 0 comments · May be fixed by #402

Comments

@ryanseipp
Copy link

Expected Behavior

actix-session should provide an option to use rustls to handle TLS as an alternative to OpenSSL, to reduce surface area and allow the end user to standardize on a single TLS implementation vs. having potentially two.

Current Behavior

actix-session only exposes redis/tokio-native-tls-comp feature flag when the redis-rs-tls-session feature is enabled. As I utilize rustls for sqlx, actix-web and anything else needing a TLS secured connection, I now have two implementations of TLS in my compiled executable, and OpenSSL is dynamically linked.

Possible Solution

Expose a "redis-rs-rustls-session" feature flag to enable "redis/tokio-rustls-comp".

Steps to Reproduce

cargo new ssl && cd ssl
cargo add actix-web -F rustls-0_21
cargo add actix-session -F redis-rs-tls-session
cat Cargo.lock | grep -E '"rustls"|"openssl"'
# if actix-session used in bin, observe libssl.so.3 dynamically linked via
ldd target/debug/ssl
zbigniewzolnierowicz added a commit to zbigniewzolnierowicz/actix-extras that referenced this issue Feb 17, 2024
@zbigniewzolnierowicz zbigniewzolnierowicz linked a pull request Feb 17, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant