-
-
Notifications
You must be signed in to change notification settings - Fork 824
Require explict allowlisting of attributes and associations #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
742c863
to
8674980
Compare
@scarroll32 Ok with releasing this as Ransack 4.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo and another idea for naming the list of all attributes/associations
22be99f
to
81f1d25
Compare
Co-authored-by: lukas-eu <62448426+lukas-eu@users.noreply.github.com> Co-authored-by: Wes Oldenbeuving <wes@narnach.com>
81f1d25
to
05db5c6
Compare
I will prepare a release tomorrow. |
@scarroll32 I created a release draft. It's been a while without releases, so let me know how it looks if you have some time! Otherwise I'll just release this tommorrow™️. |
I really understood the security idea about this change. But when something doesn't have a door the path is "free". However, when all of the world need to use this door, you generate a big problem! Imagine, need to generate a key for everyone. So, this behavior break so many applications that discourages people use ransack. Because the core changed and break the whole app, forced to implement this security feature. |
Fixes #1273.