Skip to content

Require explict allowlisting of attributes and associations #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

Fixes #1273.

@deivid-rodriguez deivid-rodriguez force-pushed the improve-defaults branch 5 times, most recently from 742c863 to 8674980 Compare February 2, 2023 12:59
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review February 2, 2023 14:15
@deivid-rodriguez
Copy link
Contributor Author

@scarroll32 Ok with releasing this as Ransack 4.0?

Copy link
Contributor

@lukas-eu lukas-eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo and another idea for naming the list of all attributes/associations

Co-authored-by: lukas-eu <62448426+lukas-eu@users.noreply.github.com>
Co-authored-by: Wes Oldenbeuving <wes@narnach.com>
@deivid-rodriguez deivid-rodriguez merged commit 2922e33 into main Feb 6, 2023
@deivid-rodriguez deivid-rodriguez deleted the improve-defaults branch February 6, 2023 23:03
@deivid-rodriguez
Copy link
Contributor Author

I will prepare a release tomorrow.

@deivid-rodriguez
Copy link
Contributor Author

@scarroll32 I created a release draft. It's been a while without releases, so let me know how it looks if you have some time! Otherwise I'll just release this tommorrow™️.

@AndreyCerqueiraLima
Copy link

I really understood the security idea about this change.

But when something doesn't have a door the path is "free".
When you put a door on the path and force every player to implement a key to use this door, everything is okay when this door is just for 2 people.

However, when all of the world need to use this door, you generate a big problem! Imagine, need to generate a key for everyone.

So, this behavior break so many applications that discourages people use ransack. Because the core changed and break the whole app, forced to implement this security feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About default searchable attributes and associations
5 participants