Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Add v1 meta tag #23

Closed
milliams opened this issue Jan 6, 2020 · 5 comments
Closed

Add v1 meta tag #23

milliams opened this issue Jan 6, 2020 · 5 comments

Comments

@milliams
Copy link

milliams commented Jan 6, 2020

According to the docs, as well as following SemVer, actions should:

Move the major version tag (v1, v2, etc.) to point to the Git ref of the current release

This is so that users can just do:

uses: actions/upload-release-asset@v1

and always be on the latest, compatible release.

There is an action which claims to be able to do this automatically for you at https://github.com/marketplace/actions/actions-tagger

@eine
Copy link

eine commented Jan 6, 2020

@eregon
Copy link

eregon commented Feb 8, 2020

Indeed, it would be nice to add a v1 tag to this action, per the official versioning documentation: https://github.com/actions/toolkit/blob/master/docs/action-versioning.md

Right now, everyone is hardcoding @v1.0.1 which means it's going to be painful if something breaks as nobody would get the bug fix automatically.

@eregon
Copy link

eregon commented Feb 8, 2020

@IAmHughes @bryanmacfarlane @mscoutermarsh (based on the replies from the referenced issues)
Could one of you add a v1 tag to this action?

@bryanmacfarlane
Copy link
Member

@IAmHughes is the main contributor here. Happy to help with this and other issue if needed ...

@IAmHughes
Copy link
Contributor

I just setup that action to automate it in #27. Thanks for your patience around this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants