Multi Path Artifact Upload + Exclude Character Support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
reviewed
Jul 9, 2020
gimenete
approved these changes
Jul 9, 2020
Comment on lines
+34
to
+35
| const commonPaths = new Array<string>() | ||
| const splitPaths = new Array<string[]>() |
There was a problem hiding this comment.
What do you think on using Sets here?
There was a problem hiding this comment.
I try to avoid multi-dimensional arrays but i found it the easiest to use here. We're also guaranteed beforehand that all the searchpaths are unique so the main benefit of using a set is not needed.
Co-authored-by: Alberto Gimeno <gimenete@users.noreply.github.com>
yacaovsnc
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44 and #55
Overview
The @actions/glob npm package is used internally to search for files to upload. This package supports exclude characters, but it is useless if you can only provide a single path at a time as input. This PR adds support for correctly uploading artifacts that have multiple paths provided as input. Previously an exception would be thrown if multiple search paths were detected. The
globpackage accepts multiple search paths if they are separated by newline characters so usingpathalongside|makes it very easy.The
globpackage has a getSearchPaths function that returns the search paths that were used to find all the files. If multiple paths are used, there is the possibility that there are more than 1 search paths returned by this function.If more than 1 search path is returned, the least common ancestor of all paths is calculated and that will be used as the root directory of the artifact. The
READMEhas been updated with information to describe this behavior along with an example. I've also added an example for the "flattening" that currently happens if wildcard patterns are used.馃帹 New Readme 馃枌
Testing
There are no compat problems or breaking changes with this addition. Anyone using the v2 action with either an individual file, directory or wildcard pattern will not be effected and all existing behavior stays the same.
Regarding the new behavior: