Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat req] merging of uploads ala v3 #549

Open
jadamcrain opened this issue Apr 1, 2024 · 3 comments
Open

[feat req] merging of uploads ala v3 #549

jadamcrain opened this issue Apr 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jadamcrain
Copy link

jadamcrain commented Apr 1, 2024

What would you like to be added?

V3 allowed you to merge artifacts from multiple jobs. V4 removed this capability:

Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

This will break a lot of parallelized pipelines. For example, our pipeline builds native libraries for a number of architectures in parallel in a matrix:

https://github.com/stepfunc/dnp3/blob/1b25ad1a6ef09729d205d36d20b2168d1d4f75f1/.github/workflows/ci.yml#L199

We then upload all of the built artifacts to a common artifact name for each architecture:

https://github.com/stepfunc/dnp3/blob/1b25ad1a6ef09729d205d36d20b2168d1d4f75f1/.github/workflows/ci.yml#L241

V4 completely breaks this way of doing things without providing a work around or suggested alternative pattern.

Why is this needed?

It's a common pattern that existed in V3 and will now break many many builds in V4

@jadamcrain jadamcrain added the enhancement New feature or request label Apr 1, 2024
@SteffenL
Copy link

SteffenL commented Apr 4, 2024

I faced a similar issue but the migration guide provided the solution.

@jadamcrain
Copy link
Author

Thanks @SteffenL, I will have a look. I missed the migration guide in the release notes.

kenorb added a commit to EA31337/EA31337-indicators-common that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants