Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include explicit directory entries [feat req] #547

Open
agajdosi opened this issue Mar 21, 2024 · 1 comment
Open

Add option to include explicit directory entries [feat req] #547

agajdosi opened this issue Mar 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@agajdosi
Copy link

What would you like to be added?

In v3 the github action was adding directory entries into the zip, as could be seen in the outputs of:

zfile12 = zipfile.ZipFile("some.zip", "r")
for file in zfile11.namelist():
    print(file)

For v4:

blenderkit/__init__.py
blenderkit/addon_updater.py
blenderkit/addon_updater_ops.py
blenderkit/append_link.py
blenderkit/asset_bar_op.py
blenderkit/asset_drag_op.py
blenderkit/asset_inspector.py
[...]

For v3:

blenderkit/
blenderkit/bl_ui_widgets/
blenderkit/blendfiles/
blenderkit/client/
blenderkit/data/
blenderkit/thumbnails/
blenderkit/addon_updater.py
blenderkit/autothumb_material_bg.py
blenderkit/ui_panels.py
[...]

Why is this needed?

Missing the directory entries is not bad per se, but some other code might depend on it, for us it is CGCookie/blender-addon-updater#90.

Having option to include explicit directory entries would enable me to continue using the artifact-upload. Other options would be to allow uploading the zip directly, that way I would have the full control. But until then, I will need to upload manually again...

@nonesky666
Copy link

nonesky666 commented Apr 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants