Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] v4: Duplicate artifacts after FinalizeArtifact timeout #531

Open
jbroadus opened this issue Feb 27, 2024 · 0 comments
Open

[bug] v4: Duplicate artifacts after FinalizeArtifact timeout #531

jbroadus opened this issue Feb 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jbroadus
Copy link

What happened?

Using a self-hosted runner, uploading a fairly large artifact (5G in this case), I occasionally see this:

Finalizing artifact upload
Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/FinalizeArtifact. Retrying request in 3000 ms...

This results in two identical artifact archives.

What did you expect to happen?

When this error does not occur, a single artifact archive is posted.

How can we reproduce it?

I haven't created a repro case, but I imagine interrupting the network connection of a self-hosted runner during the finalize would do it.

Anything else we need to know?

My yaml:

      - name: Upload Artifacts
        uses: actions/upload-artifact@v4
        with:
          name: ${{ inputs.machine }}-${{ github.run_id }}
          path: "${{ steps.gather.outputs.artifacts }}/*"
          overwrite: true

What version of the action are you using?

v4.3.1

What are your runner environments?

self-hosted

Are you on GitHub Enterprise Server? If so, what version?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant