Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @actions/artifact to version 0.6.1 #286

Merged
merged 1 commit into from Dec 15, 2021

Conversation

konradpabjan
Copy link
Collaborator

Bump @actions/artifact to version 0.6.1 https://www.npmjs.com/package/@actions/artifact/v/0.6.1 which has a fix for #281

@konradpabjan konradpabjan requested a review from a team as a code owner December 15, 2021 01:17
@nschonni
Copy link
Contributor

Not sure if you want to run npm i to do #275 here instead

@konradpabjan
Copy link
Collaborator Author

konradpabjan commented Dec 15, 2021

@nschonni for the time being we're sticking with lockfileVersion of 1. There hasn't really been an initiative or major reason for us to move up to v2 (yet). In all our other first party actions like setup-node and setup-python we're still on v1. When we update one we'll probably update all of them.

Also a minor reason why we don't want to immediately move to v2 is because actions runners ship with node12 and that is what actions are executed with:

using: 'node12'

Node12 ships with v6 of NPM (npm 6.14.15 according to https://nodejs.org/en/blog/release/v12.22.6/) which uses lockfileVersion 1 so it would be a bit weird to use v2 now here (even though it would probably work). And we're not moving to a newer version of node largely for compatibility.

@nschonni
Copy link
Contributor

OK, I won't clutter up the discussion here, but the problem is that now that Node 16 is LTS and ships with NPM 8, anytime you touch the package.json file NPM 8 will upgrade to v2. It makes working with these packages annoying, because you either have to globally install NPM 6 temporarily or keep undoing the upgrades repeatedly.

@konradpabjan
Copy link
Collaborator Author

OK, I won't clutter up the discussion here, but the problem is that now that Node 16 is LTS and ships with NPM 8, anytime you touch the package.json file NPM 8 will upgrade to v2. It makes working with these packages annoying, because you either have to globally install NPM 6 temporarily or keep undoing the upgrades repeatedly.

Yeah it's a bit annoying 😕 I'll ask around internally if we would want to go ahead and upgrade the lock files for all first party actions. Though just because we're using older versions of node my hunch is we won't want to

@konradpabjan konradpabjan merged commit 82c141c into main Dec 15, 2021
@konradpabjan konradpabjan deleted the konradpabjan/artifact-0.6.1 branch December 15, 2021 14:47
@nschonni
Copy link
Contributor

I closed that other PR for now, but Node 12 is EOL in 5 months, so it might be good to look at the upgrade sooner than later https://github.com/nodejs/Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants