Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @actions/core to 1.2.6 #145

Merged
merged 2 commits into from Nov 13, 2020
Merged

Update @actions/core to 1.2.6 #145

merged 2 commits into from Nov 13, 2020

Conversation

joshmgross
Copy link
Member

@joshmgross joshmgross commented Nov 12, 2020 •
edited

This PR updates @actions/core to 1.2.6 to resolve the security vulnerabilities described in https://github.blog/changelog/2020-11-09-github-actions-removing-set-env-and-add-path-commands-on-november-16/

This is the same change as #133 but with a re-generated dist and an updated license

@joshmgross joshmgross added the dependencies Pull requests that update a dependency file label Nov 12, 2020
konradpabjan
konradpabjan approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating this.

We don't explicitly use the set-env functionality that will be deprecated but it's probably complaining because it's still in dist/index.js

@joshmgross joshmgross merged commit 3db166e into main Nov 13, 2020
@joshmgross joshmgross deleted the joshmgross/update-actions-core branch November 13, 2020 15:52
This was referenced Mar 9, 2021
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
This was referenced Mar 16, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradpabjan konradpabjan konradpabjan approved these changes

@yacaovsnc yacaovsnc Awaiting requested review from yacaovsnc

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshmgross @konradpabjan