Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec: throw error when cwd option does not exist #793

Merged
merged 2 commits into from May 7, 2021

Conversation

luketomlinson
Copy link
Contributor

Resolves #573

This will throw an error when the provided options.cwd does not exist. I believe this will also handle #737 as we are adding a try/catch at the top level which should handle any previously uncaught errors.

There is some linting, so I recommend turn whitespace diffs off for review.

@luketomlinson luketomlinson requested a review from a team as a code owner May 6, 2021 17:06
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luketomlinson luketomlinson merged commit 09e59b9 into main May 7, 2021
@luketomlinson luketomlinson deleted the bugfix/573-bad-exec-error branch May 7, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing an invalid path into @actions.exec.exec options argument throws confusing errror
2 participants