From 4a45fd8fb53bc70ec0e984ed97a0b9a34a1775b0 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Tue, 13 Apr 2021 11:43:22 -0500 Subject: [PATCH 1/2] Prepend newline for set-output --- packages/core/__tests__/core.test.ts | 9 ++++++--- packages/core/src/core.ts | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/core/__tests__/core.test.ts b/packages/core/__tests__/core.test.ts index 0e52e9b2cf..a069e89cee 100644 --- a/packages/core/__tests__/core.test.ts +++ b/packages/core/__tests__/core.test.ts @@ -159,17 +159,20 @@ describe('@actions/core', () => { it('setOutput produces the correct command', () => { core.setOutput('some output', 'some value') - assertWriteCalls([`::set-output name=some output::some value${os.EOL}`]) + assertWriteCalls([ + os.EOL, + `::set-output name=some output::some value${os.EOL}` + ]) }) it('setOutput handles bools', () => { core.setOutput('some output', false) - assertWriteCalls([`::set-output name=some output::false${os.EOL}`]) + assertWriteCalls([os.EOL, `::set-output name=some output::false${os.EOL}`]) }) it('setOutput handles numbers', () => { core.setOutput('some output', 1.01) - assertWriteCalls([`::set-output name=some output::1.01${os.EOL}`]) + assertWriteCalls([os.EOL, `::set-output name=some output::1.01${os.EOL}`]) }) it('setFailed sets the correct exit code and failure message', () => { diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts index e7e366c501..13f4dfa3f0 100644 --- a/packages/core/src/core.ts +++ b/packages/core/src/core.ts @@ -99,6 +99,7 @@ export function getInput(name: string, options?: InputOptions): string { */ // eslint-disable-next-line @typescript-eslint/no-explicit-any export function setOutput(name: string, value: any): void { + process.stdout.write(os.EOL) issueCommand('set-output', {name}, value) } From 73e1631c46601328be4287af7e0e19cbbf931cc6 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Tue, 13 Apr 2021 11:56:33 -0500 Subject: [PATCH 2/2] bump package version --- packages/core/RELEASES.md | 3 +++ packages/core/package-lock.json | 2 +- packages/core/package.json | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/RELEASES.md b/packages/core/RELEASES.md index 352efe8440..4926ebdce4 100644 --- a/packages/core/RELEASES.md +++ b/packages/core/RELEASES.md @@ -1,5 +1,8 @@ # @actions/core Releases +### 1.2.7 +- [Prepend newline for set-output](https://github.com/actions/toolkit/pull/772) + ### 1.2.6 - [Update `exportVariable` and `addPath` to use environment files](https://github.com/actions/toolkit/pull/571) diff --git a/packages/core/package-lock.json b/packages/core/package-lock.json index a1ede3d253..e262592934 100644 --- a/packages/core/package-lock.json +++ b/packages/core/package-lock.json @@ -1,6 +1,6 @@ { "name": "@actions/core", - "version": "1.2.6", + "version": "1.2.7", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/packages/core/package.json b/packages/core/package.json index ffcced43ef..a0e72b3178 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@actions/core", - "version": "1.2.6", + "version": "1.2.7", "description": "Actions core lib", "keywords": [ "github",