Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get linux version from os-release file if available #594

Merged
merged 1 commit into from May 28, 2021
Merged

Conversation

ukstv
Copy link
Contributor

@ukstv ukstv commented Oct 3, 2020

Not all Linux distributions have /etc/lsb-release file available. If you try to use local runner like https://github.com/nektos/act it fails to perform actions relying on the toolkit. Say setup-python action can not proceed because of /etc/lsb-release missing. It can not determine version of python distribution to setup for a void os version.

There is one more, apparently more widely used, file /etc/os-release that contains release version information similar to lsb-release. This pull request adds support for getting os version from /etc/os-release file.

@ukstv
Copy link
Contributor Author

ukstv commented Nov 18, 2020

So when release?

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thboop
Copy link
Collaborator

thboop commented May 28, 2021

Thanks for the contribution @ukstv we will get this released early next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants