Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add helpers for working with paths across OSes #1102

Merged
merged 1 commit into from Jun 15, 2022
Merged

core: add helpers for working with paths across OSes #1102

merged 1 commit into from Jun 15, 2022

Conversation

sethvargo
Copy link
Contributor

No description provided.

@sethvargo sethvargo requested a review from a team as a code owner May 26, 2022 16:17
@sethvargo
Copy link
Contributor Author

/cc @jmillsy @konradpabjan @thboop

konradpabjan
konradpabjan reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great!

Could you go ahead and document these new functions in the README for @actions/core: https://github.com/actions/toolkit/tree/main/packages/core

@sethvargo
Copy link
Contributor Author

@konradpabjan done

konradpabjan
konradpabjan approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'll differ for the final approval from @thboop before merging in

thboop
thboop approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@thboop thboop merged commit 00282d6 into actions:main Jun 15, 2022
@sethvargo sethvargo deleted the sethvargo/path branch June 15, 2022 17:50
@RA80533
Copy link

RA80533 commented Jun 20, 2022 •
edited

I was wondering what the purpose of these functions was compared to those from the native Path module (link). I figured it was discussed offline since it wasn't in the PR description.

I'd love to understand so I can have a better idea of when they're recommended. Thanks!

@sethvargo
Copy link
Contributor Author

Hi @RA80533 these functions are for converting from platform-specific or non-platform-specific paths, regardless of the underlying operating system.

@warnyul warnyul mentioned this pull request Jan 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradpabjan konradpabjan konradpabjan approved these changes

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sethvargo @RA80533 @konradpabjan @thboop