Include fs stats and mode in zip archive, fix "too many open files" error #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
Bushgang1981
approved these changes
Apr 29, 2024
|
actions/upload-artifact#485 looks relevant here, and could be easily fixed in the same PR by using |
|
Commit 5f62f1e should fix actions/upload-artifact#485. |
SMoraisAnsys
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
LGTM
Looking at file documentation this PR should fix actions/upload-artifact#485
rmunn
changed the title
|
@bethanyj28 - It looks like you've been doing recent work on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow Unix file permissions to be included in the zip file created by upload-artifact, fixing actions/upload-artifact#38 and probably actions/upload-artifact#37 as well.
Fixes #1722.
Fixes actions/upload-artifact#485.
This is basically #1609, rebased against the current state of the
mainbranch. But #1609 did not include themodeproperty in its call tozip.append, and my research suggests thatmodeis needed to actually include the permissions in the zip file.