Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical removal of trailing zeros breaks version number inputs not entered as strings #1682

Open
IanButterworth opened this issue Mar 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@IanButterworth
Copy link

IanButterworth commented Mar 7, 2024

Describe the bug

This issue is more general, but specifically a problem for version numbers.

Take

with:
    version: 1.10

getInput returns this as a string "1.1", whereas

with:
    version: '1.10'

getInput returns a string "1.10".

In version numbers 1.1 != 1.10, and it's not possible for the action to defend against this to tell whether the entry might have been treated as a number before being presented as a string.

Expected behavior

getInput provide a way to get the raw entry, or indicate if input has been treated as a number before being returned as a string.

Or just never drop trailing zeros..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant