Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce GITHUB_PROXY environment variable support in http-client #1664

Open
thomas-z-meyer-db opened this issue Feb 20, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@thomas-z-meyer-db
Copy link

Describe the enhancement
For complex setup with self-hosted Github Action runners were all requests toward Github hosted servers needs to go thru an intercepting webproxy please introduce support for aenvironment variable like GITHUB_PROXY or GITHUB_HTTPS_PROXY.

When the http-client detects an access towards a server hosted by GitHub, use the proxy server defined in GITHUB_PROXY.

Currently self-hosted github action runners need to set HTTPS_PROXY and NO_PROXY, which is hard to get right in a strict setups, as the semantic is wrong: it's deny listing (in NO_PROXY) instead of allow listing only certain target hosts.

By introducing a special GITHUB_PROXY or GITHUB_HTTPS_PROXY variable all traffic toward GITHUB could be forced thru intercepting web proxy, but no other traffic would be routed thru any proxy, as HTTPS_PROXY, HTTP_PROXY and NO_PROXY are widely used in different syntaxes by all kind of software.

@thomas-z-meyer-db thomas-z-meyer-db added the enhancement New feature or request label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant