Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in @actions/http-client 2.2.0 since 2.1.1: Bundle size increased by 820kB #1621

Open
mgrybyk opened this issue Jan 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mgrybyk
Copy link

mgrybyk commented Jan 10, 2024

Regression in @actions/http-client 2.2.0 since 2.1.1: Bundle size increase by 820kB

In my case it increased from 320kB to 1130kB.

@actions/http-client is a dependency of @actions/core.

Since changes in @actions/http-client from version 2.1.1 to 2.2.0 the bundle size increased by 820kB as a result of adding the undici dependency to @actions/http-client.

Sorry to say, the @actions/core automatically installs the latest v2 of @actions/http-client which is now 2.2.0 and has terribly huge undici package.

Expected result

Replace the undici with something tiny. 820kB of source code to make http requests is ridiculous.

Additional Information

The root cause is here #1547 where the undici was added.

A lightweight HTTP client optimized for building actions

not "a lightweight" anymore.

@mgrybyk mgrybyk added the bug Something isn't working label Jan 10, 2024
@mgrybyk mgrybyk changed the title Regression in @actions/http-client 2.2.0 since 2.1.1: Bundle size increase 3x times by 1Mb Regression in @actions/http-client 2.2.0 since 2.1.1: Bundle size increased by 820kB Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant