Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for @actions/github 1.0.1 #104

Closed
xt0rted opened this issue Sep 3, 2019 · 9 comments
Closed

Release notes for @actions/github 1.0.1 #104

xt0rted opened this issue Sep 3, 2019 · 9 comments
Assignees

Comments

@xt0rted
Copy link
Contributor

xt0rted commented Sep 3, 2019

I just got a PR from dependabot bumping @actions/github to version 1.0.1 but there doesn't seem to be release notes for this in the project folder, or a release/tag. Is there an easier way to see what changed than looking through the commits?

@damccorm
Copy link
Contributor

damccorm commented Sep 3, 2019

Whoops, sorry forgot to update the release notes - they should be updated now, it included a small change to enable simpler webpack configs (#101).

@damccorm damccorm self-assigned this Sep 3, 2019
@xt0rted
Copy link
Contributor Author

xt0rted commented Sep 5, 2019

Same issue with the 1.1.0 releases.

@damccorm
Copy link
Contributor

damccorm commented Sep 5, 2019

Updated, sorry about that - will get better at this

@xt0rted
Copy link
Contributor Author

xt0rted commented Sep 5, 2019

There's also a 1.1.0 update for @actions/core, are there any changes to that beside #98?

@damccorm
Copy link
Contributor

damccorm commented Sep 5, 2019

No, that's it. Will update there as well

@xt0rted
Copy link
Contributor Author

xt0rted commented Sep 7, 2019

@damccorm I was looking into this more and what I found is because this is a mono repo the package.json of each package needs to be modified like so:

   "repository": {
     "type": "git",
-    "url": "git+https://github.com/actions/toolkit.git"
+    "url": "git+https://github.com/actions/toolkit.git",
+    "directory": "packages/github"
   },

Then RELEASES.md renamed to RELEASE.md or CHANGELOG.md (as per dependabot).

That should then allow Dependabot to pull the correct change log for each package instead of showing a list of commits like it's doing now. I was going to PR the changes but wasn't sure if you wanted them made.

@bryanmacfarlane
Copy link
Member

I was going to PR the changes but wasn't sure if you wanted them made.

We would gladly accept a PR.

@xt0rted
Copy link
Contributor Author

xt0rted commented Sep 25, 2019

This change is in #143

@xt0rted
Copy link
Contributor Author

xt0rted commented Oct 1, 2019

The change log is showing in Dependabot's PRs now xt0rted/block-autosquash-commits-action#44

@xt0rted xt0rted closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants